fix(tarko): prevent frequent api/v1/models calls by memoizing callbacks#1378
Merged
fix(tarko): prevent frequent api/v1/models calls by memoizing callbacks#1378
api/v1/models calls by memoizing callbacks#1378Conversation
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ulivz
force-pushed
the
fix/models-api-frequent-calls
branch
from
459d695 to
b6a267f
Compare
ulivz
changed the title
api/v1/models calls by memoizing callbacks
cjraft
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed frequent API calls to
api/v1/modelsduring SSE responses by optimizing callback function memoization inNavbarModelSelector. The issue was caused by unstable function references triggering unnecessary re-renders and API calls.Root cause: Arrow functions
() => apiService.getAvailableModels()and(sessionId, provider, modelId) => apiService.updateSessionModel(sessionId, provider, modelId)were being created on every render, causing theuseEffectdependency array to trigger repeatedly.Solution:
useCallbackfor stable function referenceshandleModelChangedependencies to only includeactiveSessionIdPerformance impact: Eliminates infinite API call loops while maintaining full functionality.
Checklist