fix(tarko-cli): prevent console interceptor recursion in debug mode#1279
Merged
fix(tarko-cli): prevent console interceptor recursion in debug mode#1279
Conversation
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Replace logger.debug() calls with originalConsole.error() in ConsoleInterceptor to avoid infinite recursion when debug mode is enabled.
ulivz
force-pushed
the
fix/tarko-agent-cli-debug-infinite-loop
branch
from
d88d5bd to
8e351df
Compare
ulivz
changed the title
ulivz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed infinite loop issue when running
tarko run --headless --debugby preventing console interceptor recursion.Root Cause: The
ConsoleInterceptorusedlogger.debug()calls in three places:start()methodstop()methodcreateInterceptor()methodRecursion Chain:
logger.debug()internally callsconsole.*methodsconsole.*methods are intercepted byConsoleInterceptorlogger.debug()againlogger.debug()→console.*→createInterceptor→logger.debug()→ ...Solution: Replace
logger.debug()withthis.originalConsole.error()to use the original console methods directly, avoiding interception.Changes: Only 3 lines modified - minimal and precise fix.
Checklist