Merged
Conversation
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Merge modelInfoAtom, agentInfoAtom, and workspaceInfoAtom into sessionMetadataAtom - Consolidate isProcessingAtom into agentStatusAtom with derived compatibility - Maintain backward compatibility with derived atoms - Reduce state fragmentation and improve consistency - Address FIXME comment about merging session metadata atoms
ulivz
force-pushed
the
refactor/consolidate-state-atoms
branch
from
410d5e9 to
2d0f0f2
Compare
Remove modelInfoAtom, agentInfoAtom, and workspaceInfoAtom as they are no longer used anywhere in the codebase.
- Replace custom SessionMetadata with SessionItemInfo['metadata'] from server - Remove duplicate ModelInfo and AgentInfo types from frontend - Update all components to use unified sessionMetadata structure - Simplify state management by using server-side type definitions - Improve type consistency between frontend and backend - Reduce maintenance overhead from duplicate type definitions
ulivz
commented
Aug 25, 2025
multimodal/tarko/agent-web-ui/src/common/state/actions/connectionActions.ts
Outdated
Show resolved
Hide resolved
...odal/tarko/agent-web-ui/src/common/state/actions/eventProcessors/handlers/AgentRunHandler.ts
Outdated
Show resolved
Hide resolved
multimodal/tarko/agent-web-ui/src/standalone/navbar/AboutModal.tsx
Outdated
Show resolved
Hide resolved
- Add workspace to metadata instead of top-level in sessionMetadataAtom - Replace any type with proper SessionItemInfo metadata type - Use SessionItemInfo['metadata'] type for AboutModal props
ulivz
added a commit
that referenced
this pull request
Aug 31, 2025
Fix UI components to display model.displayName instead of raw modelId when displayName is configured. This resolves the regression introduced by state consolidation in PR #1237. Changes: - Add displayName field to SessionItemInfo.metadata.modelConfig interface - Update ModelSelector.tsx to show displayName || modelId for current session - Update AboutModal.tsx to show displayName || modelId in model info - Update Navbar.tsx to use displayName || modelId for width calculations Fixes: #1312
This was referenced Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate fragmented state atoms to improve maintainability and reduce complexity.
Changes:
modelInfoAtom,agentInfoAtom, andworkspaceInfoAtominto unifiedsessionMetadataAtomisProcessingAtomintoagentStatusAtomwith derived compatibilityBenefits:
Checklist