Skip to content

Fix warnings in lex.rs #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Oct 7, 2022
+7 −5
Merged

Fix warnings in lex.rs #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions crates/wit-parser/src/ast/lex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ impl<'a> Tokenizer<'a> {
Ok(ret)
}

// This is going to be used shortly for a new feature.
#[allow(dead_code)]
pub fn parse_str(&self, span: Span) -> Result<String> {
Comment thread
kulakowski-wasm marked this conversation as resolved.
let mut ret = String::new();
let s = self.get_span(span);
Expand Down Expand Up @@ -367,11 +369,11 @@ impl<'a> Tokenizer<'a> {
Some((_, '"')) => return Ok(None),
Some((_, '\\')) => match self.chars.next() {
Some((_, '"')) => '"',
Some((_, '\'')) => ('\''),
Some((_, 't')) => ('\t'),
Some((_, 'n')) => ('\n'),
Some((_, 'r')) => ('\r'),
Some((_, '\\')) => ('\\'),
Some((_, '\'')) => '\'',
Some((_, 't')) => '\t',
Some((_, 'n')) => '\n',
Some((_, 'r')) => '\r',
Some((_, '\\')) => '\\',
Some((i, c)) => return Err(Error::InvalidEscape(i, c)),
None => return Err(Error::UnterminatedString(start)),
},
Expand Down