[c#] Align lists, free alloc'ed memory before return #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
approved these changes
Sep 17, 2024
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
LGTM. There a a few whitespace changes which might not have been intentional; would you mind running cargo fmt to clean those up?
Collaborator
|
would this fix some of the align issues we were having with the tests? |
Collaborator
Author
|
If they are around lists them possibly. I'm not saying I've found all the align errors, but this one manifested with WebGPU. Have we disabled some tests because of alignment issues? If so I can try enabling those. |
Collaborator
|
I was thinking of the variants test but looks like we fixed that a couple months ago #993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the alignment of align 8 list elements. We also now use
NativeMemory.AlignedAllocfor the allocation on imports, and fix the free of these allocs to be before the return instead of at the end of the block