cranelift-jit: Fix arm64 adrp relocations #11734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The relative address accidentally got zero-extended rather than sign-extended, causing relocation targets before the adrp instruction to be 4GB off.
This was referenced Sep 23, 2025
github-actions
bot
added
the
cranelift
cfallin
approved these changes
Sep 23, 2025
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
This looks good; thanks for the fix!
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
The relative address accidentally got zero-extended rather than sign-extended, causing relocation targets before the adrp instruction to be 4GB off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative address accidentally got zero-extended rather than sign-extended, causing relocation targets before the adrp instruction to be 4GB off.