Package up exception handler state #11577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a minor refactoring of the `wasmtime-unwinder` crate to use a `Handler` structure as a "package" for the pc/fp/sp triple that's required to resume to an exception handler. Freestanding functions are now associated methods/functions of `Handler` such as finding a frame on the stack and resuming to a handler. This doesn't actually change any behavior, just moving some things around to prepare for a future refactoring.
github-actions
bot
added
cranelift
alexcrichton
requested review from
pchickey
and removed request for
a team and
fitzgen
pchickey
approved these changes
Sep 3, 2025
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
* Package up exception handler state This commit is a minor refactoring of the `wasmtime-unwinder` crate to use a `Handler` structure as a "package" for the pc/fp/sp triple that's required to resume to an exception handler. Freestanding functions are now associated methods/functions of `Handler` such as finding a frame on the stack and resuming to a handler. This doesn't actually change any behavior, just moving some things around to prepare for a future refactoring. * Fix some CI issues * Fix conditional build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a minor refactoring of the
wasmtime-unwindercrate to use aHandlerstructure as a "package" for the pc/fp/sp triple that's required to resume to an exception handler. Freestanding functions are now associated methods/functions ofHandlersuch as finding a frame on the stack and resuming to a handler.This doesn't actually change any behavior, just moving some things around to prepare for a future refactoring.