Rename "preview{0,1}" in wasmtime-wasi to "p{0,1}"
#11380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
wasi
pchickey
approved these changes
Aug 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
alexcrichton
force-pushed
the
rename-feature-gates
branch
from
dc1bf9c to
024f041
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This commit renames the `preview1` module and features to `p1` and does the same for `preview0`. This additionally cleans up the test suite a bit to share more code amongst all the implementaitons and to also move the p1 tests out of the p2 folder. This additionally adds a `p2` feature to the `wasmtime-wasi` crate but it does not currently gate the `p2` module because that'll require some more refactoring an annotations to get that working.
alexcrichton
force-pushed
the
rename-feature-gates
branch
from
024f041 to
86d2fba
Compare
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
…e#11380) * Rename "preview{0,1}" in `wasmtime-wasi` to "p{0,1}" This commit renames the `preview1` module and features to `p1` and does the same for `preview0`. This additionally cleans up the test suite a bit to share more code amongst all the implementaitons and to also move the p1 tests out of the p2 folder. This additionally adds a `p2` feature to the `wasmtime-wasi` crate but it does not currently gate the `p2` module because that'll require some more refactoring an annotations to get that working. * Fix build of the CLI * Fix build of the C API * Fix bench-api build * Fix build of examples * More renamings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the
preview1module and features top1and does the same forpreview0. This additionally cleans up the test suite a bit to share more code amongst all the implementaitons and to also move the p1 tests out of the p2 folder.This additionally adds a
p2feature to thewasmtime-wasicrate but it does not currently gate thep2module because that'll require some more refactoring an annotations to get that working.