Fix calculation of reachable DWARF #11338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single dependency graph indexed by `gimli::UnitSectionOffset` was used to contain the dependencies from every `gimli::Dwarf`. However, this is not correct because a `gimli::UnitSectionOffset` is only unique within its associated `gimli::Dwarf`. Fix by using one graph per `gimli::Dwarf`.
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
A single dependency graph indexed by `gimli::UnitSectionOffset` was used to contain the dependencies from every `gimli::Dwarf`. However, this is not correct because a `gimli::UnitSectionOffset` is only unique within its associated `gimli::Dwarf`. Fix by using one graph per `gimli::Dwarf`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single dependency graph indexed by
gimli::UnitSectionOffsetwas used to contain the dependencies from everygimli::Dwarf. However, this is not correct because agimli::UnitSectionOffsetis only unique within its associatedgimli::Dwarf.Fix by using one graph per
gimli::Dwarf.In addition to wasmtime's tests, the only testing I have done on this is to compile the component-docs tutorial using wasmtime and diff the resulting DWARF. That diff showed that this patch does affect which DWARF entries are determined to be reachable.