wasi-http: Add default-send-request feature flag #11323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian14708
force-pushed
the
feature/wasi-http-default-send-request
branch
2 times, most recently
from
ff2c14e to
5e23189
Compare
dicej
approved these changes
Jul 25, 2025
Contributor
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Looks great, thanks; just one suggestion inline.
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
(if you don't mind me doing some review too)
Thanks for this! In addition to the comments below can you add a check on CI that the crate builds without default features? For example somewhere around here
crates/wasi-http/tests/all/p2.rs
Outdated
Comment on lines
70
to
79
| #[cfg(feature = "default-send-request")] | ||
| { | ||
| Ok(types::default_send_request(request, config)) | ||
| } | ||
| #[cfg(not(feature = "default-send-request"))] | ||
| { | ||
| Err(ErrorCode::InternalError(Some( | ||
| "default-send-request feature disabled".to_string(), | ||
| )) | ||
| .into()) | ||
| } |
Member
There was a problem hiding this comment.
FWIW we generally do not test all possible combinations of features, so I think it's reasonable to leave this out and have it be a compile error if the feature is disabled and tested. My thinking is along the lines of my above comment where I'd prefer to avoid reachable always-return-error functions if possible
brian14708
force-pushed
the
feature/wasi-http-default-send-request
branch
from
5e23189 to
b617075
Compare
brian14708
force-pushed
the
feature/wasi-http-default-send-request
branch
from
b617075 to
ff403ef
Compare
brian14708
force-pushed
the
feature/wasi-http-default-send-request
branch
from
ff403ef to
e2bbde2
Compare
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
default-send-requestfeature flag to thewasmtime-wasi-httpcrate that allows disabling the default HTTP request handler implementation and its associated TLS dependencies.