Delete vm::Instance::table_grow
#11216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a further inch towards bytecodealliance#11179 by removing internal reliance on reading `VMContext` pointers and casting them to `Pin<&mut Instance>` in various contexts. Notably now only a defined table needs to be grown, which simplifies the internals of `vm::Instance` ever so slightly. This is a similar change as bytecodealliance#11211 which transitions libcalls to using `DefinedTableIndex` instead of `TableIndex`.
alexcrichton
requested review from
abrown and
fitzgen
and removed request for
a team
github-actions
bot
added
wasmtime:api
Subscribe to Label Action
This issue or pull request has been labeled: "wasmtime:api", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
This commit is a further inch towards bytecodealliance#11179 by removing internal reliance on reading `VMContext` pointers and casting them to `Pin<&mut Instance>` in various contexts. Notably now only a defined table needs to be grown, which simplifies the internals of `vm::Instance` ever so slightly. This is a similar change as bytecodealliance#11211 which transitions libcalls to using `DefinedTableIndex` instead of `TableIndex`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a further inch towards #11179 by removing internal reliance on reading
VMContextpointers and casting them toPin<&mut Instance>in various contexts. Notably now only a defined table needs to be grown, which simplifies the internals ofvm::Instanceever so slightly. This is a similar change as #11211 which transitions libcalls to usingDefinedTableIndexinstead ofTableIndex.