Conversation
- Precompile gem for Ruby 3.4 - Use Ruby 3.4 in GitHub actions
|
Thanks @saulecabrera. I have a PR cooking that should fix the Windows CI, I’ll open it later today. |
|
There's a failure on main, unrelated to Windows AFAICT; I'm trying to sanity check if it's related to the Ruby upgrade or if it's due to something else. I haven't spent a bunch of time investigating this failure; have you seen this failure before? |
|
Hmm the issue is on 3.3, looks like something related to oxidize-rb/rb-sys#475. I downloaded the artifacts and 3.3 is indeed missing: Now why aren't we seeing the fix, that's the question. |
I think it's related to how the GitHub action picks the version; it uses the first Updating the rb_sys minimum version in the gemspec should do it? Let's try that. (Also, we're on a deprecated version of the cross-gem action, |
See this comment for details: #408 (comment)
See this comment for details: bytecodealliance#408 (comment)
I've updated the workflow in my fork to use the current cross-gem action. That (with the rb-sys version bump?) should do it, but I'm running into a weird issue: the rustc process dies without any output: See this example run. I can reproduce by SSHing into the GitHub Action and:
Interestingly, interactive or subsequent builds do not suffer from this. I also found that not running sigfw as process 1 (again by editing the gem code) makes the build pass. Does that mean something is sending SIGINT to our process while it compiles? |
|
I created an issue with my finding and broader context: #418 |
See this comment for details: #408 (comment)
|
Ruby 3.4 + Windows should now be green, CI is still running compilation and tests succeeded: https://github.com/bytecodealliance/wasmtime-rb/actions/runs/12750608774/job/35545705015 |
Support Ruby 3.4:
TODOs:
wait for Minimum Ruby 3.3 version must be 3.3.5 oxidize-rb/rb-sys#475
wait for Add ruby-3.4 native gem ffi/ffi#1133 and run
bundleto re-add the ffi precompiled binaries to the lockfileFix Windows compilation issue, see this error
Investigation notes:
<stdckdint.h>if it's present.<stdckdint.h>is available, but then later fails to see it.Should be fixed once Stop pinning clang in windows ucrt oxidize-rb/actions#47 merges.Edit: that's not the right fix unfortunately. I say we merge on red and accept Ruby 3.4+Windows failing CI for now. This will not affect pre-built binaries.
I won't cut a new version right away given we're due for a Wasmtime version bump, so we'll create a new release soon for that.