Skip to content

Conversation

@cpetig
Copy link
Contributor

@cpetig cpetig commented Apr 20, 2025

This implements another part of WebAssembly/component-model#384 - needed for testing the code generation in wit-bindgen

@cpetig cpetig force-pushed the fixed-size-lists branch from 3d6c1a0 to 6934009 Compare May 5, 2025 21:46
@cpetig cpetig marked this pull request as ready for review May 5, 2025 21:48
@cpetig
Copy link
Contributor Author

cpetig commented May 5, 2025

This also updates to wasm-tools 0.230.0

@cpetig
Copy link
Contributor Author

cpetig commented May 5, 2025

@alexcrichton if you look for updating wasm-tools in wac this pull request includes updating to 0.230.0

@fibonacci1729
Copy link
Collaborator

@cpetig this LGTM; are we good to merge?

@cpetig
Copy link
Contributor Author

cpetig commented May 12, 2025

Closer inspection this evening showed that encoding.rs would need special handling for fixed size lists, so I guess it is incomplete as is, sorry!

@cpetig
Copy link
Contributor Author

cpetig commented May 12, 2025

But honestly I don't trust my understanding of all the code base involved until the tests in wit-bindgen come out ok, which requires more work on wit-bindgen and wasmtime.

As long as it looks good to you I assume that it could work as is.

And the tests in wit-bindgen require support by wac.

@fibonacci1729
Copy link
Collaborator

Sounds good. I'm happy to leave this open for awhile while the various codebases this touches solidifies a bit. Let's merge when we feel confident.

@cpetig
Copy link
Contributor Author

cpetig commented May 12, 2025

If you ever need to update wasm-tools (e.g. because of the tuple bomb prevention) this patch should work well enough, I just can't tell whether it is correct enough for full fixed size list support.

@cpetig
Copy link
Contributor Author

cpetig commented Jul 12, 2025

With a lot more tests passing in https://github.com/cpetig/wit-bindgen/tree/work-in-progress and https://github.com/cpetig/wasmtime-adapter/tree/fixed-size-list , and support for fixed size lists in wasm-component-ld main, I am now confident enough that this patch is correct.

The matching wit-bindgen and wasmtime changes need more polishing before getting merged, though.

Update: I see some changes not originally intended by me (changing from wac 0.7.0-dev to wac 0.7.0 - I guess I merged another branch and should take a look at the history.

@cpetig cpetig force-pushed the fixed-size-lists branch from 9aa7cde to 461419c Compare July 12, 2025 15:58
@cpetig
Copy link
Contributor Author

cpetig commented Jul 12, 2025

I now removed the changes from the release-0.7.0 branch, which I assume is branching off to a stable branch and not intended to ever get merged into main.

This update will also give you the latest async dependencies (async is currently in the process of upstream into wasmtime), my guess is that another release of wasm-tools is imminent but should only bring you small fixes and performance improvements but no new functionality.

@cpetig
Copy link
Contributor Author

cpetig commented Jul 12, 2025

In short: Good to merge 😉

@fibonacci1729 fibonacci1729 merged commit 1750683 into bytecodealliance:main Jul 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants