Use RESOLVE_NO_SYMLINKS on Linux when following symlinks is disabled #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a bug where a forward slash is the last element of a symlink directory path and `open_dir_nofollow` is used. If a symlink is created to a directory without specifying an absolute path, then the path behind the symlink does not error when opened with `open_dir_nofollow`. Take these two symlinks: ``` > ls -l /home/ylk/test-dir-symlink* lrwxrwxrwx 1 ylk ylk 24 Feb 19 21:15 /home/ylk/test-dir-symlink -> /local/home/ylk/test-dir/ lrwxrwxrwx 1 ylk ylk 8 Feb 19 21:27 /home/ylk/test-dir-symlink2 -> test-dir/ ``` Without this patch, the following behavior is observed when using open_dir_nofollow: test-dir-symlink/ -> error test-dir-symlink -> error test-dir-symlink2 -> error test-dir-symlink2/ -> **no error**
Author
|
cancelling this and opening a CR from a branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where a forward slash is the last element of a symlink directory path and
open_dir_nofollowis used.If a symlink is created to a directory without specifying an absolute path, then the path behind the symlink does not error when opened with
open_dir_nofollow.Take these two symlinks:
Without this patch, the following behavior is observed when using open_dir_nofollow:
test-dir-symlink/ -> error
test-dir-symlink -> error
test-dir-symlink2 -> error
test-dir-symlink2/ -> no error