fix(SelectMenu, TextInput): Add Required field and omitempty to TextInput.Label#1672
Merged
FedorLap2006 merged 7 commits intobwmarrin:masterfrom Feb 14, 2026
Merged
Conversation
glotchimo
approved these changes
Nov 7, 2025
glotchimo
left a comment
glotchimo
left a comment
There was a problem hiding this comment.
Great, ran into the same, glad to see this up, hope it lands soon. Great work on the Label stuff
FedorLap2006
requested changes
Nov 8, 2025
|
Your changes seem to be working, i was able to use them in my project successfully. Thank you! |
|
@Tesohh do you plan on updating this pr in near future? |
Contributor
|
would be nice to merge/finish this to fix #1674 |
FedorLap2006
force-pushed
the
fix-modal-gotchas
branch
from
02010cc to
e5cca7c
Compare
FedorLap2006
changed the title
Required field to SelectMenu and omitempty to TextInput.LabelRequired field and omitempty to TextInput.Label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, (thanks for merging my
Labels PR by the way), I was adding modals to my bot and run into a few minor issues.RequiredfieldSelectMenu. (as seen in https://discord.com/developers/docs/components/reference#user-select)TextInput.Labelbeomitemptyso that we don't get an error if we don't specify a Label on the TextInput (which is unsupported, and would have given an error in both cases that it is specified or not) (https://discord.com/developers/docs/components/reference#text-input)