Add VerifyUnmarshalInteraction() for performance & convenience#1633
Open
mikeb26 wants to merge 1 commit intobwmarrin:masterfrom
Open
Add VerifyUnmarshalInteraction() for performance & convenience#1633mikeb26 wants to merge 1 commit intobwmarrin:masterfrom
mikeb26 wants to merge 1 commit intobwmarrin:masterfrom
Conversation
This commit adds VerifyUnmarshalInteraction() which combines VerifyInteraction() and Interaction.UnmarshalJSON(). This eliminates the extra data copying that VerifyInteraction() does to put the http body back into the http request for the caller. Additionally, this reduces code for callers following the common verify()/read()/unmarshall() pattern into a single function call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds VerifyUnmarshalInteraction() which combines VerifyInteraction() and Interaction.UnmarshalJSON(). This eliminates the extra data copying that VerifyInteraction() does to put the http body back into the http request for the caller. Additionally, this reduces code for callers following the common
verify()/read()/unmarshall() pattern into a single function call.