Bugfix: add recover logic in session listen go routines to prevent program crash#1588
Open
crisismaple wants to merge 1 commit intobwmarrin:masterfrom
Open
Bugfix: add recover logic in session listen go routines to prevent program crash#1588crisismaple wants to merge 1 commit intobwmarrin:masterfrom
crisismaple wants to merge 1 commit intobwmarrin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panics in session listen/heartbeat methods would cause main process crash since there is no recover logic in those go routines, fix this issue by adding recover logic in those go routines:
2024/12/26 05:04:33 [DG0] wsapi.go:82:Open() error connecting to gateway wss://gateway.discord.gg/?v=9&encoding=json, dial tcp: lookup gateway.discord.gg: no such host
2024/12/26 05:04:33 [DG0] wsapi.go:908:reconnect() error reconnecting to gateway, dial tcp: lookup gateway.discord.gg: no such host
2024/12/26 05:04:34 [DG0] wsapi.go:908:reconnect() error reconnecting to gateway, Get "https://discord.com/api/v9/gateway": dial tcp: lookup discord.com: no such host