fix: prepare build of the version with security fixes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashmish
commented
Nov 5, 2024
| @@ -1,2 +1 @@ | |||
| node_modules/ | |||
| package-lock.json No newline at end of file | |||
There was a problem hiding this comment.
it's needed to see which exact packages was used at the time of bundling, as well as the tools that bundled it
bashmish
commented
Nov 5, 2024
| { | ||
| "name": "@bundled-es-modules/cookie", | ||
| "version": "2.0.0", | ||
| "version": "2.0.1", |
There was a problem hiding this comment.
the original idea was that the version here needs to follow the version of the original packages, but it's not the case here and too late to fix
I'm improvising, in this case I tried to check for backwards compatibility and see 2.0.1 fit given the previous version bundled was 0.5.x (hard to say which exactly given the lack of the lock file before, see this PR #3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.