Always set CNB_TARGET_* variables during detect, build, and generate#1317
Merged
natalieparellano merged 1 commit intorelease/0.17.5from Mar 12, 2024
Merged
Always set CNB_TARGET_* variables during detect, build, and generate#1317natalieparellano merged 1 commit intorelease/0.17.5from
natalieparellano merged 1 commit intorelease/0.17.5from
Conversation
when the Buildpack API version is at least 0.10. Previously, we only set these variables when the Platform API version was at least 0.12. But, newer Buildpack APIs expect these variables regardless of the Platform API version. If we are on an older platform, derive the target variables from the base image OS. Fixes #1308 Signed-off-by: Natalie Arellano <narellano@vmware.com>
jabrown85
approved these changes
Mar 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.17.5 #1317 +/- ##
==================================================
+ Coverage 66.03% 66.03% +0.01%
==================================================
Files 95 95
Lines 7108 7118 +10
==================================================
+ Hits 4693 4700 +7
- Misses 1996 1998 +2
- Partials 419 420 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
edmorley
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 15, 2024
To pick up this backported fix: buildpacks/lifecycle#1317 ...so that these images still work after the removal of the `CNB_TARGET_*` env vars workaround in: heroku/base-images#260 Release notes: https://github.com/buildpacks/lifecycle/releases/tag/v0.17.5 Full changelog: buildpacks/lifecycle@v0.17.4...v0.17.5 GUS-W-15225541.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the Buildpack API version is at least 0.10.
Previously, we only set these variables when the Platform API version was at least 0.12. But, newer Buildpack APIs expect these variables regardless of the Platform API version. If we are on an older platform, derive the target variables from the base image OS.
Fixes #1308
Summary
Backporting #1309 to 0.17.x
See #1309 (comment)
Release notes
The
lifecyclewill always set CNB_TARGET_* variables during detect, build, and generate