Skip to content

Conversation

@petetomasik
Copy link
Contributor

@petetomasik petetomasik commented Sep 23, 2025

Fixes #1599

  • Adds new EnableECRCredentialHelper parameter that allows the Amazon ECR Credential Helper to be disabled in the ECR plugin. Defaults to true.
  • Allows for pipeline-level overrides using the BUILDKITE_PLUGIN_ECR_CREDENTIAL_HELPER env var:
steps:
  - label: ":docker: Docker Build"
    env:
      BUILDKITE_PLUGIN_ECR_CREDENTIAL_HELPER: "false"  # Override Stack param
      command: "docker build ."

@petetomasik petetomasik requested a review from a team as a code owner September 23, 2025 13:48
@scadu
Copy link
Contributor

scadu commented Sep 23, 2025

@petetomasik tests are failing with /etc/buildkite-agent/hooks/environment: line 112: ECR_CREDENTIAL_HELPER_ENABLED: unbound variable.
I reckon those should be set in packer/linux/conf/bin/bk-install-elastic-stack.sh, at least that seem to be the regular place.

@petetomasik petetomasik merged commit fc403a1 into main Sep 26, 2025
1 check passed
@petetomasik petetomasik deleted the SUP-4803-configurable-ecr-cred-helper branch September 26, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with Docker + ECR in v6.41.5 - can't login by docker when used with assume role

4 participants