Cleanup base AMI build logic #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petetomasik
reviewed
Sep 22, 2025
Fix ref to cleanup.sh
scadu
force-pushed
the
cleanup_if_changed_SUP-4787
branch
from
e6be0e3 to
6d791a9
Compare
petetomasik
approved these changes
Sep 25, 2025
scadu
added a commit
that referenced
this pull request
Sep 26, 2025
After merging #1597, goss test started failing with missing refresh_authorized_keys.timer. Looking closer, it looks like Packer overrides `/tmp/conf` directory with content of `../shared/conf`.
scadu
added a commit
that referenced
this pull request
Nov 4, 2025
After merging #1597, `managerFilePatterns` for `install-buildkite-agent` scripts no longer matched their actual path, resulting in breaking custom manager. This PR fixes this issue. Additionally, `prBodyTemplate` is replaced with `prBodyNotes` as per Renovate's docs (https://docs.renovatebot.com/configuration-templates/#pr-body): > Change the entire layout/flow by using prBodyTemplate (we do not recommend this) > Add a note by using prBodyNotes This, hopefully, fixes the issue with missing version numbers in the PR body, example: #1601
scadu
added a commit
that referenced
this pull request
Nov 4, 2025
After merging #1597, `managerFilePatterns` for `install-buildkite-agent` scripts no longer matched their actual path, resulting in breaking custom manager. This PR fixes this issue. Additionally, `prBodyTemplate` is replaced with `prBodyNotes` as per Renovate's docs (https://docs.renovatebot.com/configuration-templates/#pr-body): > Change the entire layout/flow by using prBodyTemplate (we do not recommend this) > Add a note by using prBodyNotes This, hopefully, fixes the issue with missing version numbers in the PR body, example: #1601 fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean separation of components between
baseandstackAMIs.This change should get us closer to use all the benefits of the base AMI split.