chore: use WaitGroup.Go where possible#3755
Merged
DrJosh9000 merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
2 tasks
wolfeidau
approved these changes
Mar 11, 2026
Member
wolfeidau
left a comment
wolfeidau
left a comment
There was a problem hiding this comment.
NICE love these automated fixes 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to a better pattern for using waitgroups.
Context
I personally desire to modernise the agent codebase to use Go 1.25 features.
Changes
Replace
wg.Add(n) ... go func() { defer wg.Done() ... }pattern withwg.Go(func() { ... })Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I used
go fix -waitgroup ./...(from Go 1.26) to get the easy ones, and found and fixed a few others manually.