Generate a warning when cache is specified on self-hosted jobs#3743
Merged
Generate a warning when cache is specified on self-hosted jobs#3743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we allow for cache configuration to be present on self-hosted jobs, we also want to highlight this in the job log output for any job that has this configuration present. While there's no explicit action that needs to be taken, nor does the presence of the config change anything for the job executing, we do want to surface that there is unsupported configuration for the job being executed.
An example of the output for a job with these changes included.
Context
Part of PS-1743
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I used
ampto implement this. Before committing and pushing I ran through the changes locally, both running Jobs and the tests. I double-checked the tests against our other tests for having them match the same style we use here.