fix: handle multiple lifecycle hooks without closed pipe reuse#3741
Merged
DrJosh9000 merged 2 commits intomainfrom Mar 11, 2026
Merged
fix: handle multiple lifecycle hooks without closed pipe reuse#3741DrJosh9000 merged 2 commits intomainfrom
DrJosh9000 merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The agent startup lifecycle hook runner supports multiple hook paths (
HooksPath+AdditionalHooksPaths), but the shared output pipe writer was closed inside the per-hook loop.That means the first hook could run successfully, then the second hook attempted to write to a closed pipe and failed with:
io: read/write on closed pipeImpact
When users configure additional lifecycle hook paths, startup/shutdown hooks can fail even though hook scripts themselves are valid.
This is user-visible and can break agent bootstrap behaviour in environments that rely on multiple global hook directories.
Reproduction
Re-enabled
TestAgentStartupHookWithAdditionalPaths, which previously failed with the closed-pipe error on the second hook execution.Fix
w.Close()/wg.Wait()inside the loopThis preserves streaming log output while preventing closed-pipe reuse across hooks.
Testing
go test ./clicommand -run 'TestAgentStartupHookWithAdditionalPaths|TestAgentStartupHook|TestAgentShutdownHook' -count=1