Skip to content

PS-1663: log s3 credential source for visibility #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhming0 merged 1 commit into from
Mar 3, 2026
+10 −0
Merged

PS-1663: log s3 credential source for visibility #3723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/artifact/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,16 @@ func NewS3Client(ctx context.Context, l logger.Logger, bucket string) (*s3.Clien
o.UsePathStyle = usePathStyle
})

creds, credErr := cfg.Credentials.Retrieve(ctx)
if credErr == nil {
profile := cmp.Or(os.Getenv("BUILDKITE_S3_PROFILE"), os.Getenv("AWS_PROFILE"))
if creds.Source == "buildkiteEnvProvider" {
l.Info("S3 credentials found in Buildkite environment (BUILDKITE_S3_ACCESS_KEY_ID, BUILDKITE_S3_SECRET_ACCESS_KEY)")
} else {
l.Info("S3 credentials loaded from the default AWS credential chain or BUILDKITE_S3_PROFILE, profile: %q", profile)
}
}

l.Debug("Testing AWS S3 credentials for bucket %q in region %q...", bucket, cfg.Region)

// Test the authentication by trying to list the first 0 objects in the bucket.
Expand Down