Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have a markdown file,
EXPERIMENTS.md, that's intended to document the currently active experiments on the agent. However, our approach to actually updating this file has been a little scattershot, and it hasn't always stayed up to date.This PR adds a test that ensures that all active experiments have entries in the file, and that promoted ones are absent. It also uppdates the file such that is documents all currently active experiments.
Context
While reviewing #3713, i was about to suggest adding the new experiment to
EXPERIMENTS.md, but then realised that we haven't been doing that, either.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Amp wrote the descriptions for the experiments added the file, lightly edited by me.