Make bucket-url optional for cache commands#3690
Merged
Conversation
The bucket-url flag is not required when using the LocalHostedAgents store type. The zstash library handles validation based on the store type returned by the API - requiring bucket-url for S3 stores while explicitly rejecting it for LocalHostedAgents. This allows hosted compute jobs to use cache commands without needing to specify a bucket URL. Amp-Thread-ID: https://ampcode.com/threads/T-019c1779-ae35-7259-b2eb-860fb137fdd3 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
--bucket-urlflag optional forcache saveandcache restorecommands.Why
The
bucket-urlflag is not required when using theLocalHostedAgentsstore type (used by Buildkite hosted compute). Thezstashlibrary already handles validation based on the store type returned by the API:This allows hosted compute jobs to use cache commands without needing to specify a bucket URL.
Changes
validate:"required"tag fromBucketURLinCacheConfigstructTesting