Skip to content

PB-1575: in k8s mode, write BUILDKITE_ENV_FILE to /workspace#3683

Merged
zhming0 merged 1 commit intomainfrom
ming/pb-1575
Jan 27, 2026
Merged

PB-1575: in k8s mode, write BUILDKITE_ENV_FILE to /workspace#3683
zhming0 merged 1 commit intomainfrom
ming/pb-1575

Conversation

@zhming0
Copy link
Contributor

@zhming0 zhming0 commented Jan 27, 2026

Description

$BUILDKITE_ENV_FILE is currently broken in k8s stack as /tmp isn't a shared volume containers in the same pod.

This PR updated job_runner so in k8s mode, env files are created in /workspace, it's the hardcoded workspace location for agent k8s stack.

I plan to add the test coverage for this as we upgrade agent version in agent k8s stack.

Context

part of PS-1575

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go tool gofumpt -extra -w .)

Disclosures / Credits

LLM and light baby sitting.

@zhming0 zhming0 requested review from a team January 27, 2026 03:55
@zhming0 zhming0 merged commit 21724f7 into main Jan 27, 2026
2 checks passed
@zhming0 zhming0 deleted the ming/pb-1575 branch January 27, 2026 04:19
@zhming0 zhming0 mentioned this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants