Conversation
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
Contributor
Author
|
Keen on knowing, too, if we already have plans to support the existing pattern; If so I'll happily adjust this PR so it doesn't look for a future config state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The kubernetes stack allows
checkout: skip: trueto be set in the step config, but using non-k8s doesn't support this without the use of a plugin. By adding this flag/env var reading we allow for a future whereskip_checkout: truecan be set in the step (BUILDKITE_SKIP_CHECKOUT)This also allows agents to run with
--skip-checkout, which means folks can ensure that they can have a fleet of agents in a certain queue which won't checkout.Context
A lot of folks use third party plugins to achieve this, and the k8s supports it as a first class citizen.
Changes
SkipCheckoutas an agent configuration optionskip_checkoutconfig option--skip-checkoutinstartandbootstrapcheckout_test.goandcheckout_integration_test.goTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
All me babyyyyyyy.