Skip to content

Adjust agent_start default shell to use /bin/bash, with fallback to /usr/bin/env bash#3667

Merged
zhming0 merged 1 commit intomainfrom
ming/adjust-agent_start-default-shell
Jan 13, 2026
Merged

Adjust agent_start default shell to use /bin/bash, with fallback to /usr/bin/env bash#3667
zhming0 merged 1 commit intomainfrom
ming/adjust-agent_start-default-shell

Conversation

@zhming0
Copy link
Contributor

@zhming0 zhming0 commented Jan 13, 2026

Description

We recently merged #3661, but we are having a second thought about using /usr/bin/env for all linux case. This PR reduce the impact of #3661 by doing a simple /bin/bash detection first before trying /usr/bin/env.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go tool gofumpt -extra -w .)

Disclosures / Credits

Me and LLM

@zhming0 zhming0 requested a review from a team January 13, 2026 02:41
Copy link
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhming0 zhming0 merged commit d5a035f into main Jan 13, 2026
2 checks passed
@zhming0 zhming0 deleted the ming/adjust-agent_start-default-shell branch January 13, 2026 02:58
@zhming0 zhming0 mentioned this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants