More custom artifact bucket fixes #3615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moskyb
force-pushed
the
more-custom-artifact-bucket-fixes
branch
15 times, most recently
from
6e08c36 to
dabe156
Compare
zhming0
reviewed
Dec 9, 2025
Contributor
zhming0
left a comment
zhming0
left a comment
There was a problem hiding this comment.
I see this PR is in draft. But looks good, left some comments
moskyb
force-pushed
the
more-custom-artifact-bucket-fixes
branch
from
dabe156 to
6b9acb0
Compare
moskyb
force-pushed
the
more-custom-artifact-bucket-fixes
branch
from
6b9acb0 to
a1cc922
Compare
2 tasks
DrJosh9000
reviewed
Dec 10, 2025
.buildkite/Dockerfile-e2e
Outdated
Comment on lines
10
to
12
| && rm -rf awscliv2.zip aws \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* |
Contributor
There was a problem hiding this comment.
These cleanups don't seem like much of a win, because the image is only used once...
moskyb
force-pushed
the
more-custom-artifact-bucket-fixes
branch
from
a1cc922 to
a40297e
Compare
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3607, we partially fixed an issue where artifacts uploaded to a customer-managed artifacts bucket would be prefixed with an extra
/, leading to the artifacts not being downloadable.However, in that PR, there was a case that we missed. This PR adds code to cover the missed case, as well as adding an end-to-end test to verify that the behaviour is working as intended, preventing the issue from recurring.
Context
PS-1470
The original PR
Some infra PRs to create the infra the E2E tests need:
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
As with the original PR, i used Amp as a tool to investigate the original issue, as well as several testing issues i encountered along the way. In some cases it was useful, and in others it led me on wild goose chases.