Skip to content

Conversation

@DrJosh9000
Copy link
Contributor

Description

YAML will be easier to edit in separate files than within Go string literals.

Context

https://linear.app/buildkite/issue/PB-1011/store-test-pipelines-in-individual-files

Changes

Similar to agent-stack-k8s

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go tool gofumpt -extra -w .)
  • It works

Disclosures / Credits

I did not use AI tools at all

@DrJosh9000 DrJosh9000 requested a review from a team December 4, 2025 04:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have conflicting feeling about this. I wonder if it's wise to keep both options?

Maybe we can help a bit by injecting the agent/queue bit in the yaml?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but my stance isn't very strong on this topic so I will approve

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but my stance isn't very strong on this topic so I will approve

@DrJosh9000 DrJosh9000 merged commit 833a2c5 into main Dec 4, 2025
2 checks passed
@DrJosh9000 DrJosh9000 deleted the pb-1011-store-test-pipelines-in-individual-files branch December 4, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants