agent pool: Send error after disconnecting #3596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhming0
approved these changes
Nov 25, 2025
This was referenced Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Undo the rearrangement of the agent pool error channel that happened in #3576.
Context
Fixes bug introduced in #3576.
Prior to #3576, the deferred Disconnect call would happen before sending the error value on the error channel. #3576 looked correct, but made Disconnect happen after sending the error value. The agent pool can return as soon as it has read the error channel N times, and the whole agent can exit very soon after. Disconnect is deferred, so if the error channel send happens before the worker returns, the Disconnect API request can still be in flight while the whole program is exiting, so it may not complete.
Changes
See Description.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Me.
I guess I am both the arsonist and the firefighter in this instance?