feat: pass in pod-template-name annotation on jobs built from podTemp…#879
Merged
Conversation
0722a14 to
10e64d1
Compare
10e64d1 to
5f2008b
Compare
zhming0
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lates
Summary
buildkite.com/pod-template-nameannotation to K8s Jobs and their pod templates when apodTemplateis specified in the pipeline's Kubernetes pluginbuildkite.com/*annotations (build-url,build-branch,build-repo, etc.) inBuild()Why
https://linear.app/buildkite/issue/A-1161/uber-agent-stack-k8s-expose-podtemplate-in-annotations
Test plan
TestBuildPodTemplateAnnotation— verifies annotation is set on both the Job and pod template whenpodTemplateis specifiedTestBuildNoPodTemplateAnnotationWhenAbsent— verifies no annotation is set when no pod template is usedgo build ./...passes cleanly