Skip to content

feat: pass in pod-template-name annotation on jobs built from podTemp…#879

Merged
ss1909 merged 1 commit into
mainfrom
sneha/add-podTemplateName
May 6, 2026
Merged

feat: pass in pod-template-name annotation on jobs built from podTemp…#879
ss1909 merged 1 commit into
mainfrom
sneha/add-podTemplateName

Conversation

@ss1909
Copy link
Copy Markdown
Contributor

@ss1909 ss1909 commented May 6, 2026

…lates

Summary

  • Adds a new buildkite.com/pod-template-name annotation to K8s Jobs and their pod templates when a podTemplate is specified in the pipeline's Kubernetes plugin
  • The annotation is stamped alongside the existing buildkite.com/* annotations (build-url, build-branch, build-repo, etc.) in Build()

Why

https://linear.app/buildkite/issue/A-1161/uber-agent-stack-k8s-expose-podtemplate-in-annotations

Test plan

  • TestBuildPodTemplateAnnotation — verifies annotation is set on both the Job and pod template when podTemplate is specified
  • TestBuildNoPodTemplateAnnotationWhenAbsent — verifies no annotation is set when no pod template is used
  • go build ./... passes cleanly

@ss1909 ss1909 marked this pull request as ready for review May 6, 2026 01:41
@ss1909 ss1909 requested a review from a team as a code owner May 6, 2026 01:41
@ss1909 ss1909 force-pushed the sneha/add-podTemplateName branch from 0722a14 to 10e64d1 Compare May 6, 2026 01:58
@ss1909 ss1909 force-pushed the sneha/add-podTemplateName branch from 10e64d1 to 5f2008b Compare May 6, 2026 01:59
@quinn-diesel quinn-diesel requested a review from a team May 6, 2026 02:34
@ss1909 ss1909 enabled auto-merge May 6, 2026 04:11
@ss1909 ss1909 merged commit 2ee989b into main May 6, 2026
3 checks passed
@ss1909 ss1909 deleted the sneha/add-podTemplateName branch May 6, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants