fix: Init controller-runtime logger before GetConfigOrDie#867
Merged
Conversation
GetConfigOrDie uses the controller-runtime internal logger, which defaults to a no-op. This means any errors or warnings from GetConfigOrDie (e.g. missing kubeconfig) are silently swallowed. Initialize the logger via klog.SetLogger before the call so that these messages are visible through our configured slog handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetConfigOrDie()is currently silently failing because the controller-runtime internal logger defaults to a no-opklog.SetLoggerbefore callingGetConfigOrDie()so errors and warnings (e.g. missing kubeconfig) are surfaced through our configured slog handlerTest plan
Verify
go run .outputBefore:
After fix: