A-1136: stop detecting init container failure for sidecar containers#862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a pod completes, native sidecar init containers (
restartPolicy: Always) are terminated by the kubelet. If any sidecar exits with a non-zero code — either from SIGKILL (137) after the grace period or SIGTERM (143) if the process doesn't handle it gracefully —failOnInitContainerFailuremisinterprets this as an init container startup failure and attempts to fail the already-finished Buildkite job, which returns 404.At high scale (200+ concurrent jobs), this creates a burst of blocking 404 API calls that stalls the informer event loop, delaying new job pickup.
Fixes #827.
Fix
Skip init containers with
RestartPolicy: AlwaysinfailOnInitContainerFailure. These are native K8s sidecar containers that run alongside main containers — their non-zero exit codes during pod shutdown are expected, not failures.