Skip to content

PIPE-2128: customise job reservation expiry#847

Merged
zhming0 merged 2 commits into
mainfrom
bm/custom_reservation_time
Apr 14, 2026
Merged

PIPE-2128: customise job reservation expiry#847
zhming0 merged 2 commits into
mainfrom
bm/custom_reservation_time

Conversation

@mcncl
Copy link
Copy Markdown
Contributor

@mcncl mcncl commented Mar 27, 2026

Description

This adds a flag, --reservation-expiry-seconds for use with the controller. This mirrors the current functionality available when using the Stacks API.

Changes

  • Adds a ReservationExpirySeconds flag to the CLI flags options
    • Sets default values from the documentation, this differs from the stacks API code, which I have another PR in for with a fix in the comment
  • Implements its use in the the controller and the reserver
  • Extends testing to cover the use of this option in the controller and the reserver via the fake server.
  • gofumpt -l -w . picked up a couple of imports that weren't in alphabetical order and adjusted

also related to A-1071

@mcncl mcncl requested a review from a team as a code owner March 27, 2026 03:29
@mcncl mcncl changed the title PF-9552 : customise job reservation expiry PIPE-2128: customise job reservation expiry Mar 27, 2026
Copy link
Copy Markdown
Contributor

@zhming0 zhming0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhming0 zhming0 merged commit 9774312 into main Apr 14, 2026
3 checks passed
@zhming0 zhming0 deleted the bm/custom_reservation_time branch April 14, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants