Conversation
Use /bin/sh instead of ash and add auto-detection for user/group creation commands to support both Alpine (BusyBox) and glibc-based images (Ubuntu, Debian, Rocky Linux). This enables use of non-Alpine agent images which may be needed for glibc-specific features like TCP-based DNS queries (use-vc resolv.conf option). Signed-off-by: Eli Uriegas <[email protected]>
moskyb
approved these changes
Jan 28, 2026
| )} | ||
| createUserScript := generateCreateUserScript(podUser, gid, "buildkite-agent", groupname) | ||
| bootstrapCmd := fmt.Sprintf(`su buildkite-agent -c "%s && buildkite-agent-entrypoint kubernetes-bootstrap"`, gitConfigCmd) | ||
| checkoutScript := strings.Join([]string{"set -exuf", createUserScript, bootstrapCmd}, "\n") |
Contributor
There was a problem hiding this comment.
worth noting that we're losing -o pipefail here — is that what we want?
Contributor
Author
There was a problem hiding this comment.
Yeah good catch. I tried to get a portable set -o pipefail but failed, because for example in dash, set -o pipefail will end the shell even though I tried to capture it set -o pipefail || true.
I think it's fine. Our own script here don't use pipe syntax. It's arguable though, whether agent should handle the pipefail? But I think it's out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the awesome #809(@seemethere). Solve #808.
The goal remain the same:
I fixed a number of paper cuts issue in #809: