Don't deploy monitoring resources by default#707
Merged
Conversation
DrJosh9000
force-pushed
the
dont-deploy-monitoring-resources-by-default
branch
from
ea4096e to
55ba9a9
Compare
zhming0
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turn off deployment of the PodMonitor and Grafana Dashboard by default. These can be opted back in to using e.g.
or with a custom values.yaml file.
Why
Turns out that Helm can't deploy a PodMonitor if it doesn't know what it is (i.e. if the Prometheus Operator CRDs aren't installed yet). This didn't break CI because I installed kube-prometheus-stack in our CI cluster for testing the new resources.
On further reflection, we probably shouldn't be auto-deploying potentially unnecessary things anyway.