Monitoring tweaks#696
Merged
Merged
Conversation
zhming0
approved these changes
Sep 22, 2025
Contributor
zhming0
left a comment
zhming0
left a comment
There was a problem hiding this comment.
I am not familiar with the Grafana dashboard configmap syntax, so I am approving on that change blindly 😬 .
The rest look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
monitoring.namespaceto both thePodMonitorand the Grafana dashboardConfigMap${DS_PROMETHEUS}nonsense from the dashboard, as it seems to prevent the dashboard using the default Prometheus serviceWhy
Things I found while trying to use these autodeployed resources.