Deregister endpoint#682
Merged
Merged
Conversation
zhming0
approved these changes
Sep 8, 2025
| return stack, nil | ||
| } | ||
|
|
||
| func (c *Client) DeregisterStack(ctx context.Context, stackID string, opts ...RequestOption) error { |
Contributor
There was a problem hiding this comment.
As a client library I think will be nice to have code comments here.
Contributor
Author
There was a problem hiding this comment.
oh yup, good call. the arg should be called stackKey too.
moskyb
force-pushed
the
deregister-endpoint
branch
from
fcd6ce4 to
1d071d9
Compare
moskyb
force-pushed
the
deregister-endpoint
branch
from
1d071d9 to
151d0f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mostly just adds a method that uses the
deregisterendpoint, but it also adds a couple of testing bits and bobs.