PS-1049 add branch-build annotation to pods#672
Merged
Conversation
DrJosh9000
approved these changes
Aug 18, 2025
Contributor
DrJosh9000
left a comment
DrJosh9000
left a comment
There was a problem hiding this comment.
Seems obviously correct to me ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Customer request: enables querying OTEL traces by branch name. This allows distinguishing between test failures on main branch (which is not usually good) vs WIP branches (which is expected).
The OTEL collector automatically picks up pod annotations, so this will make branch information available in traces alongside existing build-url annotation.
Context
Support and #671
Changes
Added BuildBranchAnnotation constant in internal/controller/config/config.go
Set annotation in internal/controller/scheduler/scheduler.go following existing pattern
Deployment
Safe
Rollback
Safe to rollback