Skip to content

PIPE-1664: job level image attribute take precedence over controller podSpecPatch#659

Merged
zhming0 merged 1 commit into
mainfrom
mingpipe-1664
Jul 29, 2025
Merged

PIPE-1664: job level image attribute take precedence over controller podSpecPatch#659
zhming0 merged 1 commit into
mainfrom
mingpipe-1664

Conversation

@zhming0
Copy link
Copy Markdown
Contributor

@zhming0 zhming0 commented Jul 28, 2025

We want precedence order goes

  1. Job level plugin spec overrides 👇🏿
  2. Job level individual attribute, like image, overrides 👇🏿
  3. Controller level config.

This PR fixes a situation where controller level config will override job level image attribute.

@zhming0 zhming0 requested review from a team July 28, 2025 05:30
@zhming0 zhming0 requested a review from a team as a code owner July 28, 2025 05:30
Comment thread internal/controller/scheduler/build_inputs.go Outdated
Comment thread internal/controller/scheduler/scheduler.go Outdated
@zhming0 zhming0 enabled auto-merge July 29, 2025 04:52
@zhming0 zhming0 merged commit 0c341ae into main Jul 29, 2025
1 check passed
@zhming0 zhming0 deleted the mingpipe-1664 branch July 29, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants