Skip to content

PIPE-1157: Dogfooding buildkite scoped secret for the graphql token#623

Merged
zhming0 merged 1 commit into
mainfrom
ming/pipe-1157
Jun 16, 2025
Merged

PIPE-1157: Dogfooding buildkite scoped secret for the graphql token#623
zhming0 merged 1 commit into
mainfrom
ming/pipe-1157

Conversation

@zhming0
Copy link
Copy Markdown
Contributor

@zhming0 zhming0 commented Jun 13, 2025

Context: PIPE-1157

GraphQL used to be a requirement to run controller, but since v0.27 we no longer need that to run controller. We only need that to run integration test.

Therefore storing it as a k8s secret along with Agent Token no longer make sense.

This is an opportunity for us to test Buildkite scoped secret!

@zhming0 zhming0 requested a review from a team June 13, 2025 01:06
@zhming0 zhming0 requested a review from a team as a code owner June 13, 2025 01:06
@zhming0 zhming0 merged commit 6c39b3d into main Jun 16, 2025
1 check passed
@zhming0 zhming0 deleted the ming/pipe-1157 branch June 16, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants