PIPE-1072-2: fix explicitly setting job default queue causing controller to miss the job#622
Merged
Conversation
DrJosh9000
approved these changes
Jun 12, 2025
…ler to miss the job
zhming0
force-pushed
the
ming/pipe-1072-2
branch
from
78c700b to
f2695ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bk yaml looks like:
And k8s controller starts without a queue tag, the controller will miss the job because controller wants a job that has
queue=""instead.This PR fixed it on transport layer so when we poll jobs, its queue tag will always match our expectation.