Skip to content

[Breaking] drop support for unclustered setup#611

Merged
zhming0 merged 1 commit into
mainfrom
ming/pipe-1114
Jun 12, 2025
Merged

[Breaking] drop support for unclustered setup#611
zhming0 merged 1 commit into
mainfrom
ming/pipe-1114

Conversation

@zhming0
Copy link
Copy Markdown
Contributor

@zhming0 zhming0 commented Jun 4, 2025

THIS IS A BREAKING CHANGE

Linear card: PIPE-1114

After this change, unclustered agent token will be rejected, causing controller to abort.


This PR is stacked on top of:

@zhming0 zhming0 requested review from a team, DrJosh9000, moskyb and sj26 June 4, 2025 05:25
@zhming0 zhming0 requested a review from a team as a code owner June 4, 2025 05:25
Copy link
Copy Markdown
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@DrJosh9000
Copy link
Copy Markdown
Contributor

Goodbye, unclustered 🫡

Copy link
Copy Markdown
Contributor

@moskyb moskyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoops i commented without approving!

@zhming0 zhming0 force-pushed the ming/pipe-1114 branch 2 times, most recently from b92ee85 to ec6ab64 Compare June 5, 2025 03:06
Base automatically changed from ming/pipe-1071 to main June 5, 2025 03:44
@zhming0 zhming0 changed the title PIPE-1114: drop support for unclustered setup [Breaking] drop support for unclustered setup Jun 5, 2025
Comment thread internal/controller/controller.go Outdated
Comment thread internal/integration/testcase_test.go Outdated
@zhming0 zhming0 requested a review from sj26 June 11, 2025 02:02
Copy link
Copy Markdown
Member

@sj26 sj26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Not sure if you were waiting for me - but please go ahead!

Copy link
Copy Markdown
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have consensus.

@zhming0 zhming0 merged commit eae5fb6 into main Jun 12, 2025
1 check passed
@zhming0 zhming0 deleted the ming/pipe-1114 branch June 12, 2025 02:11
@willhughes-au
Copy link
Copy Markdown

As a customer: Why?

This doesn't have any advantage for us, so now we need to migrate all our agents/pipelines/etc over to this new clustered agent config, for zero benefit.

Slipping this in just makes us unable to upgrade.

@sj26
Copy link
Copy Markdown
Member

sj26 commented Jun 30, 2025

Hi @willhughes-au. Sorry, we understand this is frustrating.

We can't continue offering an unclustered mode. The implementation is completely different, and stops us shipping new features. We had to make the call that future versions of this agent stack for Kubernetes, which will need to leverage the clustered implementation, rely on clusters.

For customers like yourself happily using unclustered mode, we want to make it a transparent transition to move to clusters, and if you're operating in one cluster then it's basically invisible. Everything should be the same, there's just a cluster wrapping the outside in the implementation.

We don't have an easy button for this transition yet. But reach out and we'll make it happen for you:

[email protected], CC me: [email protected]

Same offer applies else who might stumble on this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants