Skip to content

Fix name of buildkite_deduper_onupdate_events_total metric #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJosh9000 merged 1 commit into from
May 8, 2025
Merged

Fix name of buildkite_deduper_onupdate_events_total metric #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/prometheus_metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Full metric name | Labels | Description
`buildkite_deduper_jobs_unmarked_running_total` | `source` | Count of times a job was removed from inFlight
`buildkite_deduper_onadd_events_total` | - | Count of OnAdd informer events
`buildkite_deduper_ondelete_events_total` | - | Count of OnDelete informer events
`buildkite_deduper_onupdate_event_total` | - | Count of OnUpdate informer events
`buildkite_deduper_onupdate_events_total` | - | Count of OnUpdate informer events

## job_watcher

Expand Down
2 changes: 1 addition & 1 deletion internal/controller/deduper/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var (
onUpdateEventCounter = promauto.NewCounter(prometheus.CounterOpts{
Namespace: promNamespace,
Subsystem: promSubsystem,
Name: "onupdate_event_total",
Name: "onupdate_events_total",
Help: "Count of OnUpdate informer events",
})
onDeleteEventCounter = promauto.NewCounter(prometheus.CounterOpts{
Expand Down