Skip to content

Validation for the container image name #565

Merged
nsuma8989 merged 1 commit into
mainfrom
SUP-3692-PodSpecPatch-Validation
Apr 14, 2025
Merged

Validation for the container image name #565
nsuma8989 merged 1 commit into
mainfrom
SUP-3692-PodSpecPatch-Validation

Conversation

@nsuma8989
Copy link
Copy Markdown
Contributor

Through this PR we are adding a validation for the container image name in podSpecPatch in the config provided

@nsuma8989 nsuma8989 requested a review from a team as a code owner April 14, 2025 18:44
@nsuma8989 nsuma8989 force-pushed the SUP-3692-PodSpecPatch-Validation branch from 69b4be6 to cdea138 Compare April 14, 2025 18:48
@nsuma8989
Copy link
Copy Markdown
Contributor Author

Performed manual test where I used below config for PodSpecPatch and got the error added through this PR

pod-spec-patch: containers: - name: container-0 image: example.org/MYIMAGE@latest

Here is the run I performed locally with the error:

`just run --config values.yaml

go run ./... --config values.yaml

Error: failed to parse config: container image contains uppercase letters: example.org/MYIMAGE@latest

2025/04/14 12:37:10 failed to parse config: container image contains uppercase letters: example.org/MYIMAGE@latest`

@nsuma8989 nsuma8989 force-pushed the SUP-3692-PodSpecPatch-Validation branch from cdea138 to 5996822 Compare April 14, 2025 22:12
Copy link
Copy Markdown
Contributor

@jeremybumsted jeremybumsted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nsuma8989 nsuma8989 merged commit e7daa1e into main Apr 14, 2025
1 check passed
@nsuma8989 nsuma8989 deleted the SUP-3692-PodSpecPatch-Validation branch April 14, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants