Skip to content

Fix eval of exit code returned from docker image pull #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 8, 2024
Merged

Fix eval of exit code returned from docker image pull #280

merged 7 commits into from
Nov 8, 2024

Conversation

@petetomasik
Copy link
Contributor

@petetomasik petetomasik commented Nov 6, 2024 •
edited by pzeballos
Loading

Fix eval of returned exit status from retry() function.

Fix: #279

@petetomasik petetomasik requested a review from a team as a code owner November 6, 2024 17:26
jeremybumsted
jeremybumsted approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jeremybumsted jeremybumsted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremybumsted jeremybumsted requested a review from toote November 6, 2024 17:35
toote
toote requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my comment, it would be awesome to add tests (I couldn't find any related to the retry functionality)

@petetomasik petetomasik requested a review from toote November 6, 2024 20:44
toote
toote approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, just a minor comment on the test, but it is mostly cosmetic

pzeballos
pzeballos approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@pzeballos pzeballos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@pzeballos pzeballos merged commit a559dfb into master Nov 8, 2024
1 check passed
@pzeballos pzeballos deleted the fix/retry-exit-status branch November 8, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toote toote toote approved these changes

@pzeballos pzeballos pzeballos approved these changes

@jeremybumsted jeremybumsted jeremybumsted approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure to pull docker image does not result in failed buil #109

5 participants

@petetomasik @toote @pzeballos @jeremybumsted