Skip to content

Conversation

@HackAttack
Copy link
Contributor

Implementation borrowed from TeamCity

@HackAttack HackAttack requested a review from a team as a code owner October 7, 2024 22:29
Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting idea. A few comments about all the caveats and warnings for users of this option to take into account and the wording of the documentation.

And agree with other comments about needing tests :)

Copy link
Contributor

@toote toote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 👏

@pzeballos pzeballos merged commit 6fe3f75 into buildkite-plugins:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants